Update dependency scope for DB backends #1345
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When upgrading a project from Quartz 2.3.2 to 2.5.0 we ran into the following error: ``` Exception in thread "main" java.lang.NoClassDefFoundError: com/mchange/v2/c3p0/ComboPooledDataSource at org.quartz.utils.C3p0PoolingConnectionProvider.initialize(C3p0PoolingConnectionProvider.java:187) at org.quartz.utils.C3p0PoolingConnectionProvider.<init>(C3p0PoolingConnectionProvider.java:106) at com.rms.mapping.system.scheduler.QuartzSchedulerManager$.init(QuartzSchedulerManager.scala:225) at com.rms.mapping.system.scheduler.QuartzSchedulerManager$.apply(QuartzSchedulerManager.scala:201) ``` Looking at the Gradle build, it look like the `c3p0` dependency is declared as `implementation` which means it's not exposed on the runtime class path. While the workaround from quartz-scheduler#1310 is sufficient if these types are exposed in the library API then it seems to make sense to change their declaration scope. This PR updates the dependency declaration to restore the behavior of the 2.3.x library. If these dependencies were intentionally hidden then perhaps a comment in the release notes or the README would be helpful? Signed-off-by: Nick Robison <nickrobison@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading a project from Quartz 2.3.2 to 2.5.0 we ran into the following error:
Looking at the Gradle build, it look like the
c3p0dependency is declared asimplementationwhich means it's not exposed on the runtime class path. While the workaround from #1310 is sufficient if these types are exposed in the library API then it seems to make sense to change their declaration scope.This PR updates the dependency declaration to restore the behavior of the 2.3.x library.
If these dependencies were intentionally hidden then perhaps a comment in the release notes or the README would be helpful?
Fixes issue #1310
Changes
Checklist
git commit -son my commits, and submit this code under terms of the Apache 2.0 license and assign copyright to the Quartz project owners(If you're not using command-line, you can use a browser extension )
In submitting this contribution, I agree to the terms of contributing as referred to here:
https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md